Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #2291

Merged
merged 66 commits into from
Jul 12, 2023

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Jul 12, 2023

⚠️ This drops Makara support

Merge upstream changes up to 7e54a30

Conflicts

None

Ported changes

  • 9f078e2 (note: part of the CSS is unused in glitch-soc)
  • 4534498
  • 20e85c0
  • e0d230f (note: glitch-soc does not actually use this component at the moment)

Merge upstream changes up to 41a5055

Conflicts

  • app/serializers/initial_state_serializer.rb:
    Upstream renamed an initial state parameter, where we had extra ones.
    Renamed as upstream did.
  • app/workers/feed_insert_worker.rb:
    Upstream wrapped database query in a block, we had extra database queries because of the DM timeline.
    Moved everything in the block.

Ported changes

Postponed changes (TODO)

Skipped changes

Merge upstream changes up to 610cf6c

Conflicts

  • app/models/trends.rb:
    Conflict due to glitch-soc's code splitting trends mailing depending on type.
    Ported upstream's changes.

Ported changes

Merge upstream changes up to ea10feb

Conflicts

None

Ported changes

Merge upstream changes up to 8e0fd2d

Conflicts

  • .github/workflows/build-image.yml:
    Upstream changed how releases are tagged, we don't have releases.
    Ignored the changes

Ported changes

Postponed changes

Merge upstream changes up to 82e477b

Conflicts

  • db/migrate/20180831171112_create_bookmarks.rb:
    Upstream ran a lint fix on this file, but this file is different in glitch-soc because the feature was added much earlier.
    Ran the lint fix on our own version of the file.

Ported changes

None

Additional changes

renchap and others added 30 commits July 8, 2023 00:12
…ter (mastodon#25693)

Co-authored-by: emilweth <7402764+emilweth@users.noreply.github.com>
mjankowski and others added 24 commits July 12, 2023 10:08
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Port 9f078e2 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port 4534498 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port 20e85c0 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port e0d230f to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `app/serializers/initial_state_serializer.rb`:
  Upstream renamed an initial state parameter, where we had extra ones.
  Renamed as upstream did.
- `app/workers/feed_insert_worker.rb`:
  Upstream wrapped database query in a block, we had extra database
  queries because of the DM timeline.
  Moved everything in the block.
… in web UI

Port ceeb2b8 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `app/models/trends.rb`:
  Conflict due to glitch-soc's code splitting trends mailing depending on type.
  Ported upstream's changes.
…n web UI

Port 338a0e7 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port c27b82a to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port af54bf5 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port ea10feb to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `.github/workflows/build-image.yml`:
  Upstream changed how releases are tagged, we don't have releases.
  Ignored the changes
Port 1392f31 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `db/migrate/20180831171112_create_bookmarks.rb`:
  Upstream ran a lint fix on this file, but this file is different in
  glitch-soc because the feature was added much earlier.
  Ran the lint fix on our own version of the file.
@ClearlyClaire ClearlyClaire marked this pull request as ready for review July 12, 2023 18:18
Copy link

@Plastikmensch Plastikmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall okay to me.
I'm just very confused by ceeb2b8 and what it's trying to achieve. It supposedly allows to see the explore page even when trends are disabled, but still all links navigating to it are hidden? I fail to see the point, unless I'm missing something.

@ClearlyClaire
Copy link
Author

Looks overall okay to me. I'm just very confused by ceeb2b8 and what it's trying to achieve. It supposedly allows to see the explore page even when trends are disabled, but still all links navigating to it are hidden? I fail to see the point, unless I'm missing something.

My understanding is that it changes the UI to not hide /explore and so when the user opts out of seeing the trends in the sidebar. It changes that option from hiding the “Trending now” and hiding “Explore” to only hiding “Trending now”

@Plastikmensch
Copy link

My understanding is that it changes the UI to not hide /explore and so when the user opts out of seeing the trends in the sidebar. It changes that option from hiding the “Trending now” and hiding “Explore” to only hiding “Trending now”

Oooooooh I see.
I completely forgot about the user setting and thought this was about the server setting.
Thanks for clarifying!
It still hides it in the advanced UI though, but that wasn't touched upstream either and I'm not sure it's a bad thing.

@ClearlyClaire ClearlyClaire merged commit bb98d97 into glitch-soc:main Jul 12, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.